First time setup improvements
mirh opened this issue · comments
- It is my understanding that
Settings.Global.ADB_WIFI_ENABLEDcan programmatically detect what it has written on the tin- I believe the WRITE_SECURE_SETTINGS permission could also allow for that to be started automatically
- none of that is going to be a thing before 11, but for starters you could at least check the normal ADB_ENABLED property
- improve the "waiting for device respond" line, that leaves clueless users like in #65
LADB sowed
Enter pairing code: failed to parse address
It is my understanding that
Settings.Global.ADB_WIFI_ENABLEDcan programmatically detect what it has written on the tin* [ ] I [believe](https://old.reddit.com/r/androiddev/comments/j6p8q4/wireless_debugging_in_android_11_off/gte71jd/) the WRITE_SECURE_SETTINGS permission could also allow for that to be started automatically
none of that is going to be a thing before 11, but for starters you could at least check the normal ADB_ENABLED property
improve the "waiting for device respond" line, that leaves clueless users like in Android 9 ladb can't use #65
Very very true, I will have it not toggle the state for A10 and below! And I will implement those other changes as well.
Added
Nothing of what I left unchecked seems to have happened actually.
Nothing of what I left unchecked seems to have happened actually.
I already had the auto wireless debugging thing in a previous update. And I made sure that it only happens on Android 11+. And I added a little note in the new update for more details about the waiting screen. I think that's what you meant right?
Duh, I see #49 now sorry.
Idk why I started talking/worrying about A11 when my phone didn't even have it.
I think you are still missing the super dumb ADB_ENABLED check though.
Duh, I see #49 now sorry. Idk why I started talking/worrying about A11 when my phone didn't even have it.
I think you are still missing the super dumb ADB_ENABLED check though.
Ah right. Does this actually enable USB debugging when you set the global setting? I know some stuff it doesn't actually toggle.
https://stackoverflow.com/questions/11314145/looking-to-enable-and-disable-toggle-adb-or-usb-debugging-using-command-line-o
It should AFAICT, but you need some unclear special permission to modify the setting. Unclear if it couldn't even just be the usual WRITE_SECURE_SETTINGS.
Nevertheless at least the check should be always possible.
https://stackoverflow.com/questions/11314145/looking-to-enable-and-disable-toggle-adb-or-usb-debugging-using-command-line-o It should AFAICT, but you need some unclear special permission to modify the setting. Unclear if it couldn't even just be the usual WRITE_SECURE_SETTINGS. Nevertheless at least the check should be always possible.
Looks good?
Looks gucci to me, even though I didn't personally test it.