Duplicate Readings for the Sunday of the Forefathers (2 Sundays before Christmas)
mamyt opened this issue · comments
mamyt commented
Due to the way things are organised, the JAVA programme gives duplicate readings for the Sunday of the Forefathers. The problem needs to be verified that there are no further issues. I provided an easy fix.
Aleksandr Andreev commented
Can you be a bit more specific? Which XML files are offending?
mamyt commented
The files are languages/xml/9908.xml (which is the base file for the Sunday
of the Forefathers) and the sequence of pentecostarion files for Sunday (*e.g.
*languages/xml/{9232, 9239, 9246, 9253, 9260}.xml). When the combined in
the JAVA version of the programme, the readings were invariably duplicated.
I corrected it by commenting out in 9908.xml the readings. Now there is
only a single set of readings.
…On Wed, 30 Dec 2020 at 13:31, Aleksandr Andreev ***@***.***> wrote:
Can you be a bit more specific? Which XML files are offending?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSMKOI2PDSFJKPELSY4DLLSXMMQNANCNFSM4VODLUIA>
.
Aleksandr Andreev commented
IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".
mamyt commented
The file is still referenced in the individual pentecostarion files for
creating the service on the given day. I will need to look into that and
will give further information later. We got rid of floaters everywhere and
replaced it by fixed files.
…On Wed, 30 Dec 2020 at 15:40, Aleksandr Andreev ***@***.***> wrote:
IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSMKOKKQ5NPWMYSYMPXTX3SXM3WTANCNFSM4VODLUIA>
.
mamyt commented
If you look in the file pentecostarion/253.xml, which states the
commemorations to be observed on this particular Sunday, you will see that
the listed commemorations are: 9902 (before Theophany), 9904 (after
Christmas), 9906 (before Christmas), 9908 (of the Forefathers), and finally
9253 (the particular Sunday itself). If we specify the readings in both
9908 and 9253, which we used to, then we will have duplicate readings.
…On Wed, 30 Dec 2020 at 15:40, Aleksandr Andreev ***@***.***> wrote:
IIRC, 9908.xml is obsolete because the Perl API no longer uses "floaters".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSMKOKKQ5NPWMYSYMPXTX3SXM3WTANCNFSM4VODLUIA>
.