Add fontWeight types

Question

Add fontWeight types

satvikpendem opened this issue 4 years ago · comments

Looks like the only options available for fontWeight are those in this image. This means I can't set it to medium, light, semibold, or others, as well as not being able to specify these weights as between 100 and 900. Is there a way around this? I can add these types in a PR if needed, just let me know where to add them.

Also, I've noticed insufficient types for other CSS properties as well, I can help on working to fix them.

Tylor Steinberger · Answer 1 · Wed Dec 18 2019 00:16:47 GMT+0800 (China Standard Time)

Hey @satvikpendem I think you could get around this by updating TypeStyle's csstype to the latest version as it definitely has number in the types for font-weight (https://raw.githubusercontent.com/frenic/csstype/master/index.d.ts, ctrl+f for 'FontWeightAbsolute').

And ideally we'd update the dependency directly in TypeStyle for these fixes.

Satvik Pendem · Answer 2 · Wed Dec 18 2019 07:10:11 GMT+0800 (China Standard Time)

Thanks, how would I update csstype, just yarn upgrade csstype?

Tylor Steinberger · Answer 3 · Thu Dec 19 2019 11:12:38 GMT+0800 (China Standard Time)

I'm not 100% sure, but I think you do yarn csstype to add it to your dependencies. Your suggestion may work as well, I'm less familiar with yarn these days.

I'd try them both out and report back how you make out.