'PascalCase' and 'snake_case' never get migrated in variable-name rule

[Sophia]

PascalCase and snake_case configuration options never get migrated to eslint because formats variable is not used anywhere.
See:

tslint-to-eslint-config/src/converters/lintConfigs/rules/ruleConverters/variable-name.ts

Lines 40 to 63 in 7c92c87

 const formats = ["camelCase", "UPPER_CASE"]; 
  
 if (hasCheckFormat && allowPascalCase) { 
     formats.push("PascalCase"); 
 } 
 if (hasCheckFormat && allowSnakeCase) { 
     formats.push("snake_case"); 
 } 
  
 if (!hasCheckFormat) { 
     camelCaseRules.push({ 
         selector: "variable", 
         format: ["camelCase", "UPPER_CASE"], 
         leadingUnderscore: "forbid", 
         trailingUnderscore: "forbid", 
     }); 
 } else { 
     camelCaseRules.push({ 
         selector: "variable", 
         format: ["camelCase", "UPPER_CASE"], 
         leadingUnderscore: allowedLeadingUnderscore ? "allow" : "forbid", 
         trailingUnderscore: allowedTrailingUnderscore ? "allow" : "forbid", 
     }); 
 } 

[Edwin Kofler]

It looks like this fix got merged and released, but the issue wasn't automatically closed? Just trying to make sure no potential future contributors are confused :)

[Josh Goldberg ✨]

...huh, you're right! Thanks @hyperupcall 😄