typescript-eslint / tslint-to-eslint-config

Converts your TSLint configuration to the closest possible ESLint equivalent. πŸš€

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`import/no-internal-modules` is not a great substitution for TSLint's `no-submodule-imports`

ProdigyChrisLight opened this issue Β· comments

πŸ› Bug Report

  • tslint-to-eslint-config version: 2.6.0
  • ESLint version: 7.26.0
  • Node version: 10.16.1

Actual Behavior

Relates to: #175

import/no-internal-modules is not a great substitution for TSLint's no-submodule-imports. no-submodule-imports prevents submodules from other node packages from being imported, where import/no-internal-modules will reject submodule imports from the same package. The latter is configurable, but not in a way that provides parity with the former.

Expected Behavior

A rule should be substituted that provides the same behavior as no-submodule-imports. This issue is being discussed here: import-js/eslint-plugin-import#1430

Reproduction

Examples can be found at import-js/eslint-plugin-import#1430

πŸ‘ thanks for filing @ProdigyChrisLight!

Until some equivalent rule is provided per the linked issue, it sounds like we'll have to put a notices notice in the converter for no-submodule-imports that explains the difference.

πŸ‘ thanks for filing @ProdigyChrisLight!

Until some equivalent rule is provided per the linked issue, it sounds like we'll have to put a notices notice in the converter for no-submodule-imports that explains the difference.