twitter / algebird

Abstract Algebra for Scala

Home Page:https://twitter.github.io/algebird

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

binary-incompatible changes for 0.13

sritchie opened this issue · comments

These are changes we'd like before we release a binary-incompatible 0.13.

  • remove deprecated group/ring for future/try in algebird-util
  • convert all LawsEquiv versions to take an Equiv, and deprecate the Equiv version.
  • remove count min sketch legacies - legacy.{ CountMinSketchMonoid, CMS } (what do you think, @isnotinvain? Are there are uses at Twitter? It's been deprecated since 0.8.1)
  • add explicit return types to instances, like implicit val group in AveragedValue.scala

Small binary-compatible changes:

  • Change the generated product algebras to short-circuit if the passed-in iterator is empty
  • change the AveragedValue.+ test to use BigInt vs Long so we get full coverage

remove view bounds to doubles and replace with Numeric[T] style:

eg. https://github.com/twitter/algebird/pull/589/files#diff-030402b91914cb17675146d882df3148R52

We also want 2.12 support.

Update re: legacy.* -- we don't use any at Twitter

nice!

Other than 2.12, these are all closed.