twitter-together / action

:bird: A GitHub action to tweet from a repository

Home Page:https://github.com/marketplace/actions/twitter-together

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update to Node.js LTS

MattIPv4 opened this issue · comments

What’s missing?

The project should be running on the latest LTS release of Node.js.

Why?

The project currently runs on Node.js 12 which was EOL'ed as of April this year.

Alternatives you tried

N/A

Agree, I just did it on a ton of repositories using https://github.com/gr2m/octoherd-script-bump-node-version-in-workflows, setting --node-version "lts/*", but not yet on my personal account. Doing it right now

actually nevermind, I miss understood. I bump the used node versions in CI via gr2m/twitter-together@f7123bb, but your issue is about bundling the action code itself, right?

runs.using in action.yml can now be set to nod16 as per https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-using-nodejs-v16, do you want to send a pull request?

It's a bit of both -- updating the action to use Node 16, but also updating the repo to it (setting an .nvmrc file for it [I'm introducing it at v12 in #177], and updating to lockfile v2)

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀