twitchtv / twirp

A simple RPC framework with protobuf service definitions

Home Page:https://twitchtv.github.io/twirp/docs/intro.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Provide auto-instrumentation for OpenTelemetry standard

BrianGreenhill opened this issue · comments

First off, thanks so much for twirp!

The OpenTelemetry project has a repo containing autoinstrumenters for widely used packages (like net/http and others). This issue is to track work on creating auto-instrumentation for twirp. I'm interested to hear your thoughts. Is this something you would be open to for this project?

Thanks for your interest. We would be open to OpenTelemetry support, but it is not something we would actively work on. What changes would it need for hooks / interceptors?

It shouldn't require any changes to twirp itself. It can be implemented as a middleware in combination with a server hook. There are some examples in public repos already. One example: https://github.com/chengjiagan/twirp-opentelemetry/

This issue is stale because it has been open 60 days with no activity. Remove stale label / comment or this will be closed in 5 days