README alludes to the ability to generate python servers, but this doesn't seem to be the case
iandelahorne opened this issue · comments
We're evaluating various RPC frameworks here at Patreon, and I suggested we look into Twirp since it seemed to have the ability to generate Python servers (we're a Python shop).
Specifically, the line (in README.md) This repo only has the official generators, which write out Go and Python code, while not specifically stating that Python servers are generated, also doesn't completely rule it out.
To prevent disambiguity, this might be something you want to add to the table, as well as reformatting to This repo only has the official generators for Go (client & server) and Python (client)
Pasting my comment from the slack channel.
We have an internal python server implementation that we use on a couple of services. We can clean it up and open source/contribute.
Current opinions up for debate:
- Server is an asgi server (abstracted so wsgi should be possible without a lot of work)
- We have a context object that we use similar to go. (There's no context cancelling on it yet)
- The context object forces use of a logger, defaults to structlog.
@ofpiyush - any rough estimates on the timeline to clean up and eventually release?
Didn't realise there was pull for it!
I'll ping folks in the company on Monday and post an update as soon as I find a taker.
Update:
Mandatory WFH for corona had slowed everything down. We're picking this up this friday in our 20% time 😄
We figured that none of the python servers are open to public internet and there's no sensitive information in the repo so here's the link to our current version.
We'll remove verloop specific things and bad practices, add tests, documentation here and make proper releases over the next few weeks.
https://github.com/verloop/vtwirp
@spenczar what is the eventual goal here? Should we work towards merging this into the main repo some day?
@ofpiyush please feel free to submit a PR adding a link to vtwirp when you are ready. I think it makes the most sense for new clients and servers to exist in their own repositories to establish clear ownership.
@dpolansky we can close this now as the readme has also changed.
This issue is stale because it has been open 60 days with no activity. Remove stale label / comment or this will be closed in 5 days