twisty / formsy-react-components

Bootstrap components for a formsy-react form.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Using ref with callbacks vs strings

SachaG opened this issue · comments

Right now this codebase uses the ref="string" pattern a lot:

https://github.com/twisty/formsy-react-components/search?utf8=✓&q=ref

But the React docs mention this approach will be deprecated in favor of callbacks:

https://facebook.github.io/react/docs/more-about-refs.html

Also, for some weird reason string refs have been causing errors in certain situations, while callback refs don't. Would you consider a PR to replace the strings by callbacks?

Yes, go ahead!