`towncrier check` should not fail on revert commits that *remove* a news fragment
glyph opened this issue · comments
Glyph commented
If you're reverting a PR to un-do a change that removes the newsfragment before a release so it isn't in the changelog, the PR should succeed its towncrier newsfragment check
Adi Roiban commented
Thanks for the report
Just some extra info
There is also the release PR that removes the news fragments.
For the release PR the check is skipped based on the fact that the commit changes the NEWS.rst file.
In theory, we can merge the skip check for both release and revert PRs.
I would prefer to have separate checks.
The idea is that for a release PR you want to make sure there are no release fragment files left on the branch.