Avoid `bytes` type in test process output
bignose-debian opened this issue · comments
Ben Finney commented
A few of the unit test cases make direct comparison to objects of type bytes
. This can fail when the terminal stream is not in the assumed hard-coded encoding.
Instead, the test cases should avoid direct use of bytes
where text is intended.
Either by re-writing what the test case is comparing; or by decoding the process output using the stream's actual encoding.
Ben Finney commented
The branch wip/issue/479/avoid-bytes-for-command-output (in my personal fork repository) contains a series of commits to address this issue.
The branch currently merges cleanly to the 'trunk' branch.