Giters

twisted / nevow

Web Application Construction Kit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test failure on Twisted 13.2 (and probably earlier)

mithrandi opened this issue · comments

commented

PR #30 changed the log message format in nevow.test.test_appserver.Logging.test_oldStyle to match the format in Twisted 14.0. Unfortunately, this does not match the format used in earlier versions of Twisted, leading to this test failure:

[FAIL]
Traceback (most recent call last):
  File "/«PKGBUILDDIR»/debian/python-nevow/usr/lib/python2.7/site-packages/nevow/test/test_appserver.py", line 193, in test_oldStyle
    ['"fakeaddress2" - - faketime "GET /foo HTTP/1.0" 200 6 '
  File "/usr/lib/python2.7/dist-packages/twisted/trial/_synctest.py", line 356, in assertEqual
    % (msg, pformat(first), pformat(second)))
twisted.trial.unittest.FailTest: not equal:
a = ['fakeaddress2 - - faketime "GET /foo HTTP/1.0" 200 6 "fakerefer" "fakeagent"']
b = ['"fakeaddress2" - - faketime "GET /foo HTTP/1.0" 200 6 "fakerefer" "fakeagent"']


nevow.test.test_appserver.Logging.test_oldStyle
commented

The simplest way to fix this would be to require Twisted 14.0. Debian unstable currently only has Twisted 13.2, so I disabled this test in the Debian package for now, but this probably isn't a concern for users installing Nevow directly.

commented

I think this is fixed.