twilio-labs / serverless-toolkit

CLI tool to develop, debug and deploy Twilio Functions

https://www.twilio.com/docs/labs/serverless-toolkit

twilio-run Node.js v14 upgrade

krisdover opened this issue 2 years ago · comments

Kris Dover commented 2 years ago

According this upgrade guide, Twilio Runtime will no longer support Node.js v12 when its LTS ends on April 30th, 2022, however twilio-run still displays a warning that the Twilio Serverless Runtime only supports Node.js v12.x which is coming from https://github.com/twilio-labs/serverless-toolkit/blob/main/packages/twilio-run/src/checks/nodejs-version.ts#L4. Also, there are numerous code references to the default deployment runtime being node12, e.g. https://github.com/twilio-labs/serverless-toolkit/blob/77551cdb1931f13e2b9f847b8fa2787fb6d9a247/packages/twilio-run/src/templating/defaultConfig.ts.

Phil Nash commented 2 years ago

Good news! This PR has been raised to handle this.

Kris Dover commented 2 years ago

Awesome, thanks @philnash! 👍

Dominik Kundel commented 2 years ago

This has been shipped in the latest version :)