Add testing via jest

Question

Add testing via jest

dkundel opened this issue 5 years ago · comments

Dominik Kundel commented 5 years ago

We should add some basic testing using jest. This might require some refactoring to make the code a bit more testable.

Dan Gilkerson · Answer 1 · Wed Oct 02 2019 01:10:30 GMT+0800 (China Standard Time)

I'd like to work on this

Dominik Kundel · Answer 2 · Wed Oct 02 2019 01:12:14 GMT+0800 (China Standard Time)

That would be great :) let me know if you need anything from me!

Dan Gilkerson · Answer 3 · Wed Oct 02 2019 01:15:00 GMT+0800 (China Standard Time)

Is there a reason node_modules are checked in?

Dominik Kundel · Answer 4 · Wed Oct 02 2019 01:23:11 GMT+0800 (China Standard Time)

Yes those are the production dependencies only. It's a GitHub actions thing. i described it in #6

Dan Gilkerson · Answer 5 · Wed Oct 02 2019 23:01:08 GMT+0800 (China Standard Time)

I exported a function in main to test since I wanted to minimize the changes in case there were other changes on going. Probably should pull the code out of main.js when things are stable.