Move to TypeScript

Question

Move to TypeScript

dkundel opened this issue 5 years ago · comments

The current GitHub Action is written in JavaScript. All dependencies support TypeScript and we should just move this project to TypeScript to have some additional type safety.

Sree Palaparthi · Answer 1 · Wed Oct 02 2019 05:04:13 GMT+0800 (China Standard Time)

Can I take this up?

Dominik Kundel · Answer 2 · Wed Oct 02 2019 05:26:04 GMT+0800 (China Standard Time)

Absolutely!

Sree Palaparthi · Answer 3 · Wed Oct 02 2019 07:16:22 GMT+0800 (China Standard Time)

I get permission denied error when I try to push a branch

Dominik Kundel · Answer 4 · Wed Oct 02 2019 07:28:24 GMT+0800 (China Standard Time)

You'll have to create a fork and then push your branch to that fork instead.

https://help.github.com/en/articles/fork-a-repo

Sree Palaparthi · Answer 5 · Wed Oct 02 2019 07:41:51 GMT+0800 (China Standard Time)

Thanks! Can you review the pull request.

Sree Palaparthi · Answer 6 · Fri Oct 04 2019 08:27:53 GMT+0800 (China Standard Time)

Thanks for approving my first open source PR! let me know if I can help with any other open issues.

Dominik Kundel · Answer 7 · Fri Oct 04 2019 09:44:34 GMT+0800 (China Standard Time)

Thank you for contributing to the project and incorporating all the feedback so quickly! We'd love to see if we can potentially send you some swag. You can find more information here: https://twil.io/hacktoberfest-swag