Clean commits
stappersg opened this issue · comments
This issue is for having a place to elaborate upcoming merge requests for me.
Some of those _MR_s will have @marlonbaeten as author.
Goal of this issue is having clean commits. Assumed is that we know that the reason for clean commits is that it is a way to tell our future selfs and co-workers what did change and for which reason.
Hi Geert, I really appreciate the effort you put in to this, with the goal to make Mailcrab even better.
Unfortunately I'm not convinced that reverting commits, and then re-applying them makes the history easier to understand. You are right that it might be better to split work into logical and small commits, I'll try my best next time.
Anyway we have this issue together with your PR's as a public record for the reasoning for all these changes.
I'll close the PR's for now - could you maybe base the version commit on main? I be glab to merge that.
be better to split work into logical and small commits
Example given #91