Don't run CI twice on PRs

Question

Don't run CI twice on PRs

sir4ur0n opened this issue 3 years ago · comments

Current CI runs twice on PRs, e.g. for #194

~~I think what we want is:~~
* Pull request
~~* Push for master only~~

Arnaud Spiwack · Answer 1 · Thu Oct 21 2021 19:23:04 GMT+0800 (China Standard Time)

Do as works for the project, but, for the record, I'm not fond of not having a CI on non-PR branches. (this was a lot of negations sorry)

Andreas Herrmann · Answer 2 · Thu Oct 21 2021 22:49:44 GMT+0800 (China Standard Time)

There is a ticket on github.community about this. Might be useful to find a solution to this.

Julien Debon · Answer 3 · Wed Oct 27 2021 16:15:47 GMT+0800 (China Standard Time)

I'm not fond of not having a CI on non-PR branches. (this was a lot of negations sorry)

If my boolean logic is still intact 😁 I agree with you (all branches should be CI-built).

Maybe it should be only push? I'm not familiar with Github CI

Arnaud Spiwack · Answer 4 · Wed Oct 27 2021 16:22:50 GMT+0800 (China Standard Time)

In my project, I activate the CI on push and PR. And it's built twice on internal PRs. Which is rather unfortunate, but I think is the most helpful to me.

Dorran Howell · Answer 5 · Wed Oct 27 2021 16:32:59 GMT+0800 (China Standard Time)

In my project, I activate the CI on push and PR. And it's built twice on internal PRs.

We do the same for Checker at the moment. To work around this we try to limit the longevity of open PRs so that we aren't triggering the double workflow runs as often (e.g. by only opening draft PRs when a feature is really going to take more than a day or so to implement or pushing batches of commits so that CI only runs on the most recent one). This approach is still a bit wasteful in terms of CI resources though.

I'm kind of thinking that it would be okay to leave this as-is for funflow since we aren't receiving a high volume of PRs at the moment. What do you think, @sir4ur0n?