Fix file input check

Question

Fix file input check

zacechola opened this issue 10 years ago · comments

Zac Echola commented 10 years ago

See discussion: https://github.com/XhmikosR/grunt-bootlint/commit/8a82a2f564dfd8be3b9cf64c3da4548295661ca2

XhmikosR · Answer 1 · Sat Sep 27 2014 23:31:26 GMT+0800 (China Standard Time)

@zacechola: this should help https://github.com/XhmikosR/grunt-bootlint/commit/b7bbf1ced5489272268a5ca49f4fe12e2d2481b7

XhmikosR · Answer 2 · Wed Oct 08 2014 06:56:55 GMT+0800 (China Standard Time)

@zacechola: maybe it will be worth borrowing the code from https://github.com/gruntjs/grunt-contrib-htmlmin/blob/master/tasks/htmlmin.js#L22 for the src/input checks.

Zac Echola · Answer 3 · Thu Oct 09 2014 03:54:07 GMT+0800 (China Standard Time)

So after beating my head here for awhile looking at how grunt's core plugins handle it, I finally figured it out.

bootlint: {
  missing_files: {
    src: ['totally/missing/thing/'],
    nonull: true
  },
}

Grunt ignores missing files unless you specifically tell it not to with the nonull option. If you do, that's when it'll log out the warning. The docs aren't super clear here, but once you start digging into the code, you'll see that's exactly what the option is used for.

Also, looks like grunt.log.warn seems to be the defacto standard with this, rather than exiting, so I'm going to leave it as is unless I can be convinced otherwise.

There's been some discussion about this for some time in grunt land. For example: gruntjs/grunt-contrib-uglify#3

Zac Echola · Answer 4 · Sat Oct 18 2014 10:56:44 GMT+0800 (China Standard Time)

Closing this as it appears to be expected behavior from Grunt to ignore missing files by default.