twbs / bootstrap

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.

Home Page:https://getbootstrap.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bootstrap 5.2.0-beta1 > not all components have been ported to CSS vars for colors

vinorodrigues opened this issue · comments

Prerequisites

Describe the issue

I have been working on adjusting the Bootstrap-Dark-5 POC to 5.2.0-beta1 and noticed some components have not been fully ported to use CSS vars. From my observations I have picked up the following:

  • .blockquote-footer > color
  • .img-thumbnail > background-color
  • .figure-caption > color
  • ...umm... the whole shebang under the forms sub-folder, e.g., .form-control > color, .form-control-plaintext. .form-select, etc.
  • + the validation color .. i.e. .was-**, .invalid-*, etc.
  • .alert-* .alert-link > color
  • .btn-close > color
  • all the .carousel-* stuff, e.g. .carousel-control-* > color
  • .offcanvas-backdrop > background-color

Reduced test cases

Not really a test case thing - I just did a search on https://github.com/twbs/bootstrap/blob/main/dist/css/bootstrap.css for classes where color was not a var(.

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v5.2.0-beta1

We've intentionally limited efforts in v5.2.0-beta1 to the /components directory of our docs (and some :root vars). Forms and more should be coming in v5.3.0. Many of the other issues mentioned here are also covered in #35857, but could be cherry-picked into an earlier release if time allows.

I can do a quick PR for the non-complicated stuff ... .blockquote-footer, .img-thumbnail, .figure-caption & .offcanvas-backdrop (#36455).

Maybe also .alert-link (#36456) and .btn-close (#36457).

I'll leave the form control and carousel stuff to smarter-than-me people.

Closing for #35319 since that's our tracking issue :).