np.fromstring is deprecated
BrianPugh opened this issue · comments
Brian Pugh commented
np.fromstring
here is deprecated:
/usr/local/lib/python3.6/dist-packages/pyexr/exr.py:241: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
np.fromstring(strings[i], dtype = precision) \
It looks like there are slight nuances between fromstring and from buffer (read only, perhaps byte order, who knows) so I wasn't comfortable making the change myself.
Thijs Vogels commented
Hi @BrianPugh,
Thanks for the report. I'm not actively using this library myself at the moment. If you use it on a regular basis, I'd be fine with changing this and seeing if things break.
Thijs
Brian Pugh commented
I'll make a pull request in the coming week; i'll play around with it
Tomi Aarnio commented
Would it be possible to make a new release to PyPI with this issue fixed? Thanks!
Thijs Vogels commented
Yes, this is in version 0.3.9 which is now on PyPI.
… On 30 Sep 2020, at 15:40, Tomi Aarnio ***@***.***> wrote:
Would it be possible to make a new release to PyPI with this issue fixed? Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGNI6IIIJO2Q5FATTVEX2LSIMYONANCNFSM4N3T6VBA>.
Tomi Aarnio commented
Great, thank you!