tvogels / pyexr

One-line EXR IO-library

Home Page:https://github.com/tvogels/pyexr

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

np.fromstring is deprecated

BrianPugh opened this issue · comments

np.fromstring here is deprecated:

/usr/local/lib/python3.6/dist-packages/pyexr/exr.py:241: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
    np.fromstring(strings[i], dtype = precision) \

It looks like there are slight nuances between fromstring and from buffer (read only, perhaps byte order, who knows) so I wasn't comfortable making the change myself.

Hi @BrianPugh,

Thanks for the report. I'm not actively using this library myself at the moment. If you use it on a regular basis, I'd be fine with changing this and seeing if things break.

Thijs

I'll make a pull request in the coming week; i'll play around with it

Would it be possible to make a new release to PyPI with this issue fixed? Thanks!

Great, thank you!