tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Missing declaration for getPointOnCurve/getDirectionOfCurve

Elvira2227 opened this issue · comments

Describe the bug
The part of the function declaration is missing. This bug corresponds to functions getPointOnCurve and getDirectionOfCurve for the entities:

  • IfcThirdOrderPolynomialSpiral #566
  • IfcSecondOrderPolynomialSpiral #551
  • IfcSeventhOrderPolynomialSpiral #552
  • IfcSine (resolved in commit 0461e5e)
  • IfcCosine #561
template <>
carve::geom::vector<3> getPointOnCurve(const EXPRESSReference<typename IfcEntityTypesT::IfcThirdOrderPolynomialSpiral>& thirdOrderPolynomial,
const typename IfcEntityTypesT::IfcParameterValue& parameter) const noexcept(false)
{
 return getPointOnCurve(thirdOrderPolynomial, parameter * this- >UnitConvert()->getLengthInMeterFactor());
}

Without this part the code never reaches functions getPointOnCurve/getDirectionOfCurve and calculates points with catresianPointList.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'CurveConverter'
  2. Scroll down to the line 2755
  3. See declarations

Expected behavior
When rendering each type of geometry, we should not see the message on the command windows that corresponding geometry is not supported yet.

CMake configuration
If applicable, list any special configurations you have selected in CMake.

  • EARLYBINDING_WITH_IFC4X3_RC4: selected