Giters

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[REF] CurveConverter::convertIfcLoop and subfunctions

christophKaiser opened this issue · comments

commented

File which is being refactored
OpenInfraPlatform::Core::IfcGeometryConverter::CurveConverterT

Functions

  • (convertIfcLoop - already refactored, just mentioned as 'root'-function)
    • convertIfcPolyLoop (in secondary scope of the intended refactoring, further inspection during refactoring)
    • convertIfcEdgeLoop
      This is one big function, which handles many subtypes. Probably, it will be split into some smaller functions. Furthermore, a few TODOs are in the code.

The need of refactoring the function convertIfcEdgeLoop came up during the implementation of IfcAdvancedFace. I was surprised that the example files in pull request #462 work, even without the existence of functions like convertIfcOrientedEdge, convertIfcEdgeCurve, or convertIfcVertex. These entities are used in the example files. Probably, they are somehow mixed into the function convertIfcEdgeLoop. With refactoring, the structure of convertIfcEdgeLoop should be cleaned up.