tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[REQUEST]Implementing corresponding functions for IfcSpline

Elvira2227 opened this issue · comments

Is your feature request related to a problem? Please describe.
In #478 new unit tests were implemented for version IFC4X3_RC4 . For "bloss", "helmert", "sine", "cosine", "cubic", "viennese bend" curves we need to add corresponing functions to support them.

Describe the solution you'd like
The function convertIfcCurveSegment shoul be updated and new overloads for getPointOnCurve and getDirectionOfCurve should be added for:

  • Sine curve (IfcSine) #553
  • Cosine curve (IfcCosine)

The function for reading IfcThirdOrderPolynomialSpiral should be added for:

The function for reading IfcSeventhOrderPolynomialSpiral should be added for:

  • Viennese Bend curve #552

The function for reading IfcSecondOrderPolynomialSpiral should be added for:

  • Helmert curve #551

The function for reading IfcPolyonmialCurve should be added for:

Additional context
For examples of implementation please see #494 and #482

Great issue description!

A note to the developer: for first-, second-, and so on -orderpolynomial, a common function can be called by all with zeros at the corresponding locations.