Giters

tudat-team / tudatpy

A Python platform to perform astrodynamics and space research.

Home Page:https://tudat-space.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Silly" default behaviour of spherical harmonics parameter sets

jo11he opened this issue · comments

commented

Spherical harmonics parameter sets created by

  • estimation_setup.parameter.spherical_harmonics_c_coefficients and
  • estimation_setup.parameter.spherical_harmonics_s_coefficients

include an entry for the degree, order (0,0) coefficient, which one should not estimate nor consider in sensitivity analyses.
Maybe this term should be excluded by default? On top (or instead), it would be helpful for the naive user to adopt a little note into the docstrings (for the API reference), that for estimation / sensitivity of GM in combination with SH coefficients, one should go through the dedicated gravitational_parameter parameter type, and add it to the parameter set alongside the spherical harmonics coefficients.

commented

Fixed in this commit:

tudat-team/tudat@10ee98a

I also added some more checks (no negative degrees, no order 0 sine coefficients).

Thanks for pointing this out!