1.6.0-RC compatibility

Question

1.6.0-RC compatibility

jameskleeh opened this issue 3 years ago · comments

I'm trying to test compilation with 1.6.0-RC-1.0.1-RC, however the constructor for MessageCollectorBasedKSPLogger has changed and thus its not compatible with this module. This is a request to get a release that is compatible with 1.6 RC

Thilo Schuchort · Answer 1 · Thu Nov 11 2021 04:11:55 GMT+0800 (China Standard Time)

As you have come to find out yourself, the internal API of the compiler changes frequently between releases, so KCT can only support one compiler version at a time or the maintenance burden would be too great. I can not depend on Kotlin 1.6.0-RC until 1.6.0 is released for good. Will a SNAPSHOT release be okay for you until then?

James Kleeh · Answer 2 · Fri Nov 12 2021 09:02:10 GMT+0800 (China Standard Time)

Yeah a snapshot release would be great!

…

On Wed, Nov 10, 2021 at 3:12 PM Thilo Schuchort ***@***.***> wrote: As you have come to find out yourself, the internal API of the compiler changes frequently between releases, so KCT can only support one compiler version at a time or the maintenance burden would be too great. I can not make a stable release of KCT depending on Kotlin 1.6.0-RC until 1.6.0 is released for good. Will a SNAPSHOT release be okay for you until then? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#222 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMCVLNF6RRHIT2UVS2A2ZLULLGZNANCNFSM5HWVSSUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Zac Sweers · Answer 3 · Mon Nov 15 2021 14:07:15 GMT+0800 (China Standard Time)

This is also broken in KSP 1.5.31-1.0.1, so it's not specific to Kotlin 1.6.0-RC

the maintenance burden would be too great

This is an incompatibility with KSP, not kotlinc and resolvable via simple release compiled against the newer version (no source changes needed)

Martin Bonnin · Answer 4 · Wed Nov 17 2021 20:39:16 GMT+0800 (China Standard Time)

Now that 1.6 is released, looks like it should be possible to update?
Dependabot actually created a PR there: #224 that failed with ETIMEDOUT so maybe it's just a matter of restarting it?

Zac Sweers · Answer 5 · Wed Nov 17 2021 23:25:01 GMT+0800 (China Standard Time)

I made a full PR at #223