trussed-dev / trussed

Modern Cryptographic Firmware

Home Page:https://trussed.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RequestUserConsent does not properly restore the ui status when interrupted or timed out.

sosthene-nitrokey opened this issue · comments

In the RequestUserConsent syscall, the ui status is saved, then set to WaitingForUserPresence and finally restored at the end of the call.

However, there are early returns in the loop that cause the restoration to not happen. This is not a very large issue as the call to process restores the status to Idle.
I think the restoration of the status should be removed as it isn't very useful since it is overridden to Idle just after.