trsvax / tapestry-bootstrap

Tapestry module for Twitter Bootstrap

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

brand link

znuamaan opened this issue · comments

Currently you can't set the brand ink to point to a specific place.

I'm having this problem also. I'm thinking the best way to solve this is remove the brand parameter and just add the HTML for the brand

<t:navbar>

Brand

/t:navbar

Then the navbar just ignores the link with class brand. Seem OK?

If you go from:

               <t:if test="brand">
                       <a class="brand" href="#"><t:delegate to="brand"/></a>
                 </t:if>

to:

                 <t:if test="brand">
                       <t:delegate to="brand"/>
                 </t:if>

and let the end user set their own link in their layout page - mines isn't /home for example

so in layout you would have:

         <p:brand>
                      <a href="/home" class="brand"/>
                      <span></span>
        </p:brand>

I add the image from css to the brand so I can use hover:

                    .navbar .brand {
                           margin-top:10px;
                          background: url(images/logo-foosba-39.png) no-repeat;
                          width:187px;
                         height:69px;

                        }

                   .navbar .brand:hover {
                          background: url(images/logo-foosba-39g.png) no-repeat;
                    }

                  .navbar .brand span {
                         display:none;
                    }

if what you are suggesting amounts to the same thing then that sounds good

I'll play around with it a bit. I like the brand parameter because it documents the feature.

Change to
<t:if test="brand">
<t:delegate to="brand"/>
/t:if