fullName in callback is inconsistent?
c-dante opened this issue · comments
Not sure what the intention is here:
route-node/modules/RouteNode.ts
Lines 142 to 161 in 71fd8d9
But in the cb
, the name
field is overwritten by this fullName
property.
This is the only time in the entire lifecycle of the RouteNode
where the name is obscured and overwritten as such.
Is this intentional? It's breaking code in router5
(and probably other places?) that rely on the callback.
It seems extra bad that the node itself doesn't get this fullName
property -- just the spread in this callback.