Giters

trivial-garbage / trivial-garbage

Portable GC-related APIs for Common Lisp.

Home Page:http://common-lisp.net/project/trivial-garbage

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

tests: unexpected OK on SBCL

avodonosov opened this issue · comments

commented

When running trivial garbadge tests on SBCL the test suite returns no failures, but still lists several tests as RT::EXPECTED-FAILURES":
hashtables.weak-value.1 hashtables.weak-key.2 hashtables.weak-key.1

Is it outdated to mark these tests as expected failures?

The test log:
https://cl-test-grid.appspot.com/blob?key=AMIfv97DXhtnmey3lh8C3P-s6SbAFyFqEFodohqccgB7UtGbKn7Qg8jlH5RanWIiC-2recfsNeWoPTbsZC1SLsjLszHLja2b3yv25TNJ_6p45mDYOWVuPIWgDkuVOdBCNGuSgSsMGjRMeLorD0fxOWwK2qPOBmZajA

commented

(Sorry for taking so long to reply; I wasn't getting notifications for these projects.) According to git-blame, those expected failures have been there since the initial commit. Back then SBCL didn't have any support for weak hashtables whatsoever. Fixed in 70717e2. Thanks!