Resolve Cardano token definitions
tomasklim opened this issue · comments
Tomáš Klíma commented
- Unify token definitions to include only fingerprint or policy id
- Enable
token-definitions
for cardano - Fix name and symbol
- Add policy id, finger print to dropdown
- Do migration
Tomáš Klíma commented
@trezor/qa
What to test?
- migration - remember cardano wallet with tokens on old suite
- check tokens, try to send tokens (this is really important!), try to send cardano, check old and new txs with older version of suite
- tokens will have different name and can have different symbol after migration in comparison with clean Suite!
- non remember wallet
- check tokens, try to send tokens, try to send cardano, check old and new txs with older version of suite
- try explorer links (account, tx, token)
- compare fingerprint, policy id with token data on explorer
Tomas B commented
Work in progress
fresh
Token section
token/contract link to explorer OKToken section
send button OKToken section
receive button OKToken section
hide button okToken section
unhide button okSend section
dropdown in amount section divided by hidden sectionSend section
send max token OK- ADA transaction link explorer OK
- Staking transaction link explorer OK
- Token transaction link explorer OK
- Policy matches explorer
- Fingerprint matches explorer
remembered/migration
- Saved wallet in 24.6.2
- Tokens present in 24.7.1
- i was able to send tokens link
- device screen does not match suite modal, i will send issue
Tomas B commented
QA OK
overall very good, sent some minor issues
Info:
- Suite version: desktop 24.7.1 (d97e8c2)
- Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.7.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
- OS: MacIntel
- Screen: 1512x982
- Device: Trezor T3T1 2.8.0 bitcoin-only (revision dd4671a5104952ef505d28d1f9e94d1484b4607a)
- Transport: BridgeTransport 2.0.33