Giters

trellisorg / platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`rx-dynamic-component@0.1.2` npm package peer dependencies

vitale232 opened this issue · comments

commented

Thanks for sharing rx-dynamic-component with the community! Such a powerful little library.

I ran into some friction while testing out the npm package. I started with a brand new ng CLI app, and added the @trellisorg/rx-dynamic-component package to my dependencies.

Like a good JS dev, I skipped over all of the peerDep warnings and started the dev server. The app was failing to compile, as I was missing two of the peerDependencies:

        "@angular/cdk": "12.2.2",
        "@ngrx/component": "^12.2.0",

FWIW, it looks like these were added in a few days ago.

Was this intentional? I'd probably be using the CDK in my app, but the @ngrx/component lib seems like an odd peer dep. It's imported in the LazyDynamicOutletModule, but I couldn't find where it's being used?

Thanks!

commented

Hey @vitale232! Thank you for reporting that! I believe I was trying something out and the dep must have ended up in there somehow. I will track it down and release a new version!

commented

@trellisorg/rx-dynamic-component@0.1.3 has been released with the @ngrx/component-store dep removed, sorry about that and thanks for reporting! I am going to work and splitting the lib up a bit so that cdk is not a needed peer dep but thats for the future