Support space before nullable directive

Question

Support space before nullable directive

patrickt opened this issue 4 years ago · comments

This is really nitpicky, but was found in the Roslyn code:

# nullable enable

#nullable enable works fine.

Damien Guard · Answer 1 · Fri Sep 25 2020 23:58:49 GMT+0800 (China Standard Time)

This seems to apply to all pre-processor directives.

Damien Guard · Answer 2 · Sat Sep 26 2020 02:30:12 GMT+0800 (China Standard Time)

Will take a second stab at this - first one has been reverted as it caused some regressions around string literals containing #.

Patrick Thomson · Answer 3 · Sat Sep 26 2020 02:36:39 GMT+0800 (China Standard Time)

Yeah, those are tricky—I encountered an #error inside a multiline interpolated string, which I don’t think we handle correctly even before this patch. I think taking a run at #16 might be the best strategy here.

Damien Guard · Answer 4 · Sat Sep 26 2020 03:11:25 GMT+0800 (China Standard Time)

I can take on #16 if you want - the structured trivia isn't defined in the formal C# spec so it's really looking at Roslyn and seeing what it does. I normally do that using the Syntax Visualizer in VS with appropriate code fragments which is obviously only a useful strategy if you're on Windows.