tree-sitter / node-tree-sitter

Node.js bindings for tree-sitter

Home Page:https://www.npmjs.com/package/tree-sitter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

pull request to fix: node-tree-sitter won't work in electron render process

guidocalvano opened this issue · comments

Hey, I'm trying to use your awesome bindings in electron, but unfortunately I get complaints that it should not be non-context aware when run in the renderer process in electron. After digging through stack overflow I found this: electron/electron#18397 where they explain you can make a node library context aware simply by applying the very small change that I applied in my pull request. I tried to build the project myself, but that proved to be quite a lot of work, probably also because I am on an m1 mac. I haven't succeeded yet. Could you have a look at my pull request to see if it works? I could of course not test it given that I cannot yet build the project, even without any changes. The build in your ci/cd worked:

#115

I went through a long process to get everything to work. I made new issue that details my steps and asks a few questions about them:
#117