skip_cleanup deprecated
mymindstorm opened this issue · comments
#2658 was closed by stale bot, this is a copy of that issue.
My builds have a deprecation warning for skip_cleanup, but the documentation still uses skip_cleanup.
https://docs.travis-ci.com/user/deployment/google-app-engine#sts=Skipping%20Cleanup
https://docs.travis-ci.com/user/deployment/#uploading-files-and-skip_cleanup
The most annoying is that setting cleanup: false does not prevent cleanup.
Preparing deploy
Cleaning up git repository with
git stash --all. If you need build artifacts for deployment, setdeploy.skip_cleanup: true. See https://docs.travis-ci.com/user/deployment#Uploading-Files-and-skip_cleanup.
(by the way, the URL above should be lowercase or the # location won't work)
Saved working directory and index state WIP on (no branch): 4944a9f Finish v0.0.1
build/bin/osx_Release/Game does not exist.
Yet, a local travis lint clearly recognizes cleanup as a valid key. So it's registered, but does nothing.
Instead, both skip_cleanup and cleanup should work during a transition period, doing opposite things, and skip_cleanup should be deprecated during that period (as currently).
Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues
Issue still present.