upf_buffer_opaque gtpu flags two assigned in a single function

Question

upf_buffer_opaque gtpu flags two assigned in a single function

sothy opened this issue 4 years ago · comments

In line 313 of gtpu_decap.c and line 318 assignes upf_buffer_opaque(b)->gtpu.flags one by one differently. I wonder it is possible to delete one line?

Andreas Schultz · Answer 1 · Wed Mar 11 2020 00:56:45 GMT+0800 (China Standard Time)

They could be merged, but I don't see that as a priority.

It is possible that the compiler sees this and merges them already for the release builds.

Andreas Schultz · Answer 2 · Mon Apr 20 2020 18:33:33 GMT+0800 (China Standard Time)

Turns out this is actually a real bug, the flags can collide.