Giters

transmissions11 / solmate

Modern, opinionated, and gas optimized building blocks for smart contract development.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"bound" not marked as "virtual" on "v7" branch

PaulRBerg opened this issue · comments

commented

I have recently created a PR in the Foundry Book repo to bump the version of Solmate recommended for users to install.

But it looks like the v7 branch has a problem - it doesn't adhere to the agreement discussed in foundry-rs/forge-std#92, that is, that the bound function will have a virtual modifier.

This means that users cannot inherit from both Forge Std's Test and DSTestPlus.

I would have created a PR to fix this myself, but it looks like on the main branch, the bound function does have the virtual modifier. So maybe you want to merge main into v7 rather than hot-patch it directly it on v7?