Giters

transmissions11 / solmate

Modern, opinionated, and gas optimized building blocks for smart contract development.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NPM package out of date

sarhaan7 opened this issue · comments

commented

  1. forge install https://github.com/Rari-Capital/solmate, give u the following function defs for supportsInterface():
    ERC1155: function supportsInterface(bytes4 interfaceId) public view virtual returns (bool)
    ERC721: function supportsInterface(bytes4 interfaceId) public view virtual returns (bool)

  2. npm install @rari-capital/solmate gives ya:
    ERC721: function supportsInterface(bytes4 interfaceId) public pure virtual returns (bool)
    ERC1155: function supportsInterface(bytes4 interfaceId) public pure virtual returns (bool)

the function state mutability changes from view to pure in the NPM package.

I can see that there was commit that changed this, so I'd assume the npm package is out of date

commented

ik— next release will be v7