Remove files not used

Question

Remove files not used

eerison opened this issue 3 years ago · comments

Erison Silva commented 3 years ago

I can see many files that should not be in the repository or it's unnecessary

I'll list them

can we remove them?

Erison Silva · Answer 1 · Mon Mar 28 2022 17:45:50 GMT+0800 (China Standard Time)

@goto-bus-stop what do you say about it?

Renée · Answer 2 · Mon Mar 28 2022 18:01:08 GMT+0800 (China Standard Time)

I havent done a release of this so I'm not sure how necessary release.sh is, but we do use Makefile and the composer lockfile. The idea behind tool/generate-example-docs.php is to keep the examples and the readme in sync, although the last time the readme was updated that script was not used 😅

.empty looks like a mistake, and imo .vscode belongs in a gitignore file, so we can definitely get rid of those two.

Erison Silva · Answer 3 · Mon Mar 28 2022 18:18:37 GMT+0800 (China Standard Time)

but we do use Makefile and the composer lockfile.

in Makefile, I can see just simple commands and I think it could be moved to composer.json, what do you think?
why do you need composer.lock in dependicy library? usually it's used for final projects only! for lib it's not used
- examples:
  - https://github.com/symfony/http-client
  - https://github.com/laravel/laravel

tool/generate-example-docs.php is to keep the examples and the readme in sync

I don't get it! we should need to write example in readme.md, I don't get why do we need to sync something?

although the last time the readme was updated that script was not used 😅
then can we assume that it's not necessary? 😄

and imo .vscode belongs in a gitignore file

yes, but not in the project, it need to be ignored in the user's machine, like this

git config --global core.excludesFile '~/.gitignore'

because this .vscode do not make part of project files!