Fix pipelines
eerison opened this issue · comments
Hey @kvz
I see that, there is a test with intermitted result, make sense to remove it?
pipeline => https://github.com/transloadit/php-sdk/runs/5418985735?check_suite_focus=true
maybe make sense try to use more unit test then functional tests?!
the initial idea is make the test always works, and trust in the pipelines, I tried to check the code But I didn't find the class that it's extending
The tests are actually tripping a security measure on the transloadit.com side because they end up sending identical signed requests, and transloadit.com requires a unique signature for each request. I'll fix them for now by making the tests run sequentially so all the signatures will have different timestamps, but this might be something that we need to improve on our API, maybe having the ability to add some salt value to a signature.
as you fixed the test, i guess we can make this issue as solved :)