Incorrect function signature prevents working with 0.71

Question

Incorrect function signature prevents working with 0.71

steven-pearson opened this issue 2 years ago · comments

@Override
public List<Class<? extends JavaScriptModule>> createJSModules() {
    return Collections.emptyList();
}

In UdpSocketsModule.java, should not be marked as @Override

Steve Pearson · Answer 1 · Wed Jan 18 2023 18:24:06 GMT+0800 (China Standard Time)

PR Raised
https://github.com/tradle/react-native-udp/pull/241/files

Steve Pearson · Answer 2 · Thu Jan 26 2023 14:57:16 GMT+0800 (China Standard Time)

PR has been approved and merged, just waiting for a new release to go out.

github-actions · Answer 3 · Wed Mar 01 2023 08:20:26 GMT+0800 (China Standard Time)

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community attention? This issue may be closed if no further activity occurs.