TS Error: Unable to resolve signature of property decorator when called as an expression.

Question

TS Error: Unable to resolve signature of property decorator when called as an expression.

speigg opened this issue 4 years ago · comments

The typings for the tracked decorator in the npm package are missing an optional specifier:

export default function tracked(obj: object, key: string | symbol, desc: PropertyDescriptor): void;

should be:

export default function tracked(obj: object, key: string | symbol, desc?: PropertyDescriptor): void;

Kristen · Answer 1 · Mon Mar 23 2020 23:02:48 GMT+0800 (China Standard Time)

Thanks for bringing this up, can you open a PR to fix by chance? If not I should be able to get to it soon.

Gheric Speiginer · Answer 2 · Tue Mar 24 2020 01:30:44 GMT+0800 (China Standard Time)

It's not actually clear to me why the type definitions you are generating are missing the optional specifier. The .ts source has the correct typings.

Kristen · Answer 3 · Tue Mar 24 2020 01:33:31 GMT+0800 (China Standard Time)

This line is probably the incorrect one: https://github.com/pzuraq/tracked-built-ins/blob/master/addon/-private/decorator.ts#L40

Gheric Speiginer · Answer 4 · Tue Mar 24 2020 01:34:21 GMT+0800 (China Standard Time)

Oh, I guess the parameters in the actual implementation are not actually included (in the generated declarations). I'll open a PR