Rails 4 Passenger 4

Question

Rails 4 Passenger 4

timuckun opened this issue 11 years ago · comments

Is this gem ready for rails 4 and passenger 4?

Michael Noack · Answer 1 · Sat May 31 2014 18:33:33 GMT+0800 (China Standard Time)

@timuckun I'm a new contributor to the project. We're about to upgrade to rails 4 ourselves (we use Unicorn instead of Passenger though) and if we find any problems we'll fix spawnling.

But just try and if there's any problems I will happily accept a pull request.

Michael Noack · Answer 2 · Sat May 31 2014 18:33:58 GMT+0800 (China Standard Time)

@timuckun It is also being tested against rails4 but that's no guarantee of it working.

Tim Uckun · Answer 3 · Sat May 31 2014 22:13:56 GMT+0800 (China Standard Time)

The problem with passenger is that it may reap your worker before the child process stops running. The question is whether the forked child will continue running after the parent process has been killed.

Justin Gordon · Answer 4 · Thu Oct 08 2015 16:13:33 GMT+0800 (China Standard Time)

Is there any issue with Passenger and Rails 4?

Michael Noack · Answer 5 · Thu Oct 08 2015 19:49:33 GMT+0800 (China Standard Time)

I honestly don't know. Our project has stopped using spawnling (we were about to upgrade to rails 4 with spawnling so would have ensured it was supported), so I'm ready to add someone who actively uses it to maintain this project.

Michael Noack · Answer 6 · Sun Aug 06 2017 15:37:00 GMT+0800 (China Standard Time)

Closing as this issue is stale. I note the code does pass in the rails 4 branch, but that the tests (at least at the time of this issue) were not covering this issue.

I'm still happy to accept PR's to address any outstanding issues.

Thanks