total-typescript / ts-reset

A 'CSS reset' for TypeScript, improving types for common JavaScript API's

Home Page:https://www.totaltypescript.com/ts-reset

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Object.keys(obj) returns a string[]

Relaxe111 opened this issue · comments

Hi, Obj.keys(obj) retruns always a string[]. With small d.ts addon we can make it more save:
original:
image
with d.ts def:
image
here is the def:

//object.d.ts
interface ObjectConstructor {
  keys<T extends object>(obj: T): (keyof T)[];
}

Do you think it is wise to add this as well to ts-reset maybe? Eventually i can do a PR, if that's will be accepted :)

Check the readme!

@mattpocock what are you supposed to find in the readme?
Also, your docs page is broken: https://www.totaltypescript.com/ts-reset#get-started

I guess this removed section: https://github.com/total-typescript/ts-reset/blob/5c20842406b9dd3fe9e533357ee6a2aa092b4e08/readme.md#rules-we-wont-add
The library has very little value without the rules you are not willing to add...