toshi0383 / TVMLKitchen

Swifty TVML template manager with or without client-server

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Showing Description Issue

Wei-Xia opened this issue · comments

Hello @toshi0383, I'm not sure if you have noticed.

In MoviePlaybackSample or other sample, the app can't open the long description in a separate screen. As the picture below shows,

1

Ideally, it should show like this way.

2

I realized there is a still open issue#27 talking about this problem, which is #27 .

I think there is a missing actionIDHandler to deal with opening a long description. I will try to solve this issue following steve228uk and your thoughts in #27.

If you have any further ideas about this issue, could you please leave here? I gonna follow up, and submit an PR after completing. Thank you! 😀

MoviePlaybackSample is using custom xmlString, so you can always add an actionID to present a new ViewController.
But the purpose of MoviePlaybackSample is to demonstrate only movie playback, so we can leave this alone for now.
But if you have time, maybe you can merge MoviePlaybackSample into SampleRecipe to start improving the sample as you suggest.