SearchRecipe.swift @escaping callback block.

Question

SearchRecipe.swift @escaping callback block.

opened this issue 8 years ago · comments

Could you please mark override func filterSearchText(_ text: String, callback: ((String) -> Void)) callback block as @escaping.

If a user is fetching search results from a remote API (very likely) the compiler rightly flags that the callback parameter could have escaped by the time remote API has responded.

Toshihiro Suzuki · Answer 1 · Mon Oct 31 2016 09:34:43 GMT+0800 (China Standard Time)

@FlaviaBondJamesBondsHusband
Thanks for pointing out! filterSearchText was meant to be @escaping, but I forgot to mark it explicitly when I converted to Swift3.
I don't think it affect execution because it is casted to JavaScript anyways.

Do you want to do a PR for me?

Deleted user · Answer 2 · Mon Oct 31 2016 22:07:50 GMT+0800 (China Standard Time)

@toshi0383 please see PR #125