Feature: Implement full tests

Question

Feature: Implement full tests

gkpty opened this issue 4 years ago · comments

Gabriel Kardonski commented 4 years ago

tests should be implemented for:

resourceExists methods
create Stack
update Stack
pull stack
push stack
delete stack

proposed solutions

Localstack is a local (self-hosted) copy of AWS cloud that can be used to test AWS services. https://github.com/localstack/localstack.
With localstack a stack can be created with torus, and then all of the resources can be tested using the resource exists method.
This should be implemented locally and in the CI/CD service (travis).
Test the resourceExists methods for an existing stack within our account (for example the stack for the torus.host site)
Use aws-sdk-mock to mock the aws-sdk calls and assert for the method responses. https://www.npmjs.com/package/aws-sdk-mock
A combination of these options

StephenTomlin · Answer 1 · Sun Oct 04 2020 02:09:15 GMT+0800 (China Standard Time)

Could I take a crack at it?

Gabriel Kardonski · Answer 2 · Sun Oct 04 2020 11:27:57 GMT+0800 (China Standard Time)

Hi @StephenTomlin Sure! I assigned the issue to you. Feel free to go about it however you like and im glad to discuss any options/hurdles you might run into. Also, if you prefer another testing framework feel free to switch out mocha.

P.S. i just merged a PR that fixes the test for the generateTemplate method and i added CI with travis CI