toptal / crystalball

Regression Test Selection library for your RSpec test suite

Home Page:https://toptal.github.io/crystalball/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Getting an exception when there's an execution map without any example groups

noralin opened this issue · comments

We're parallelizing our tests on CI and generating multiple execution maps.

Sometimes we don't actually run any tests on a specific worker, but an execution map is still generated without any example groups.

We are running into no implicit conversion of nil into Hash.

To reproduce this, in our execution maps folder, one of the yml file has just the metadata on top, but no example groups. For example, just having this in the file:

---
:type: Crystalball::ExecutionMap
:commit: <some SHA>
:timestamp: 1544572800
:version:
---

And then running CrystalBall.

Exception:

TypeError: no implicit conversion of nil into Hash
/vendor/cache/crystalball-bb6941984dbd/lib/crystalball/map_storage/yaml_storage.rb:24:in `merge!'

we have a pull request for a fix:
#104