topgrade-rs / topgrade

Upgrade all the things

Home Page:https://topgrade-rs.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Disabling `fisher` and `oh-my-fish` in `topgrade.toml` throws error despite the respective commands being picked up

j-lakeman opened this issue · comments

Running topgrade results in the following:

ERROR Failed to deserialize /Users/REDACTED/.config/topgrade.d/topgrade.toml
ERROR failed to load configuration: TOML parse error at line 18, column 20
   |
18 | disable = ["tldr", "fisher", "oh-my-fish"]
   |                    ^^^^^^^^
unknown variant `fisher`, expected one of `a_m`, `app_man`, `asdf`, `atom`, `audit`, `bin`, `bob`, `brew_cask`, `brew_formula`, `bun`, `bun_packages`, `cargo`, `chezmoi`, `chocolatey`, `choosenim`, `composer`, `conda`, `config_update`, `containers`, `custom_commands`, `deb_get`, `deno`, `distrobox`, `dkp_pacman`, `dotnet`, `emacs`, `firmware`, `flatpak`, `flutter`, `fossil`, `gcloud`, `gem`, `ghcup`, `github_cli_extensions`, `git_repos`, `gnome_shell_extensions`, `go`, `guix`, `haxelib`, `helm`, `home_manager`, `jetpack`, `julia`, `juliaup`, `kakoune`, `helix`, `krew`, `lure`, `macports`, `mamba`, `miktex`, `mas`, `maza`, `micro`, `myrepos`, `nix`, `node`, `opam`, `pacdef`, `pacstall`, `pearl`, `pip3`, `pip_review`, `pip_review_local`, `pipupgrade`, `pipx`, `pkg`, `pkgin`, `pnpm`, `powershell`, `protonup`, `raco`, `rcm`, `remotes`, `restarts`, `rtcl`, `ruby_gems`, `rustup`, `scoop`, `sdkman`, `self_update`, `sheldon`, `shell`, `snap`, `sparkle`, `spicetify`, `stack`, `stew`, `system`, `tldr`, `tlmgr`, `tmux`, `toolbx`, `vagrant`, `vcpkg`, `vim`, `vscode`, `winget`, `wsl`, `wsl_update`, `yadm`, `yarn`

However topgrade updates both fisher and oh-my-fish.

Shell related tools use the same step name, shell, Topgrade does not know what fisher and oh-my-fish are. When unknown entries appear in the config file, Topgrade uses the default config and runs the update, i.e., update all the found tools.