tooll3 / t3

Tooll 3 is an open source software to create realtime motion graphics.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Duplicating Core Operators does not populate Enum

sense-amr opened this issue · comments

commented

When duplicating a Core operator .. for use in your own namespace library ..
Enums from that operator do not populate in your duplicate version ..

image1

original with enum

image

Duplicated version with out enum

If the user case/need is to be able edit a built-in operator (without messing up everything else)
I think a faster workflow would be: Rightclick->"Symbol definition->Replace with local duplicate".
So that the operator instance settings and connectons are preserved, but use the created local duplicate.

Ideally the user would also be able to swap symbols (this would require some good error handling (or just strictly work on identical specs))

So in a sense "Replace with local duplicate" == "Duplicate as new type..." + "Swap Symbol"

commented

the quickest method is that which was already working fine .. up untill the last update..
and that is that you rename it in the parameters window .. up untill the last update .. this was working fine..
i have logged a bug with this last commit and pixtur is aware of it

commented

oh and it looks like he's managed to fix it ..
image

commented

the quickest method is that which was already working fine .. up untill the last update.. and that is that you rename it in the parameters window .. up untill the last update .. this was working fine.. i have logged a bug with this last commit and pixtur is aware of it

also your mention of something that has nothing to do with this issue .. this issue is related to ENUMS not populating when using a duplicated symbol .. not how to duplicate symbols ..

Sorry for the confusion and hijacking of this thread.
I felt it was slightly related cos I misunderstood this issue to be about initiation of the SymbolChild...

I was curious anyway about the inner workings so I made a PR

commented

no worries man i was just saying that is what THIS issue is about .. of course feel free to make any issues you want..

commented

Note to self:

This sounds like something that should be handled in the core editor functionality - i feel like all enums should be drop-down at all times in operators without needing to add an attribute

I think this should work on dev. I tested it with [Layer2d].

However there is a crash when trying to duplicate an op with an external Enum-reference (like [AnimMockStrings] because the can't access the assembly / symbol.

@sense-amr which op doesn't work for you?

Ok now i tested several Ops and they do seem now to populate Enum which is great.. and as far as i know is quite new..
there is still something that doesnt seem to populate and that is the title styles .. aka the Parameter Group .. and Padding

image

image

but i am very happy to see the enums are populating ..

Yes. We have to work on that.